chore: add manual build trigger#2342
Conversation
PeterDaveHello
left a comment
There was a problem hiding this comment.
Maybe we should extend jobs.build.if to ensure the workflow only runs on main when triggered via workflow_dispatch?
This helps avoid running repo scripts + secrets from a non-main branch.
Currently it's if: github.repository_owner == 'nodejs', we could change it to:
jobs:
build:
if: github.repository_owner == 'nodejs' && github.ref_name == 'main'
This comment was marked as outdated.
This comment was marked as outdated.
|
@nschonni You're right that |
|
By the way, with workflow_dispatch added, this workflow would also be runnable manually alongside the existing schedule. Adding concurrency could help prevent overlapping runs racing on the same updates (e.g., duplicate PRs or conflicting pushes). concurrency:
group: automatic-updates
cancel-in-progress: false |
|
The workflow is supposed to run every 15 minutes: docker-node/.github/workflows/automatic-updates.yml Lines 3 to 5 in 55e8617 In practice it seems that GitHub Actions is throttling the frequency or dropping queued jobs.
So it would be convenient to have a |
|
Actually I just realized that isn't necessary, since you can just re-run a previous job. (I just did that.) |
|
I've actually used re-running a previous job on the automatic-updates.yml workflow lately, and it seems to work quite well to speed up the process when GitHub isn't scheduling the cron jobs the way they're specified. Could we just close this PR or is there something really missing that this PR would cover? |
Description
Allowing us to manually trigger a run of the update job
Motivation and Context
Staring at

due to #2341 (comment)
Testing Details
Example Output(if appropriate)
Types of changes
Checklist